Skip to content

Added support for jshint extends option#54

Merged
cfjedimaster merged 2 commits intocfjedimaster:masterfrom
hacker112:master
Jun 2, 2014
Merged

Added support for jshint extends option#54
cfjedimaster merged 2 commits intocfjedimaster:masterfrom
hacker112:master

Conversation

@hacker112
Copy link
Copy Markdown
Contributor

@hacker112 hacker112 commented Jun 1, 2014

Added the extends options according to: jshint/jshint#1314
Implemented in the cli.js of the command line version of jshint in loadConfig on line 532:

  if (config['extends']) {
    var baseConfig = exports.loadConfig(path.resolve(config.dirname, config['extends']));
    config.globals = _.extend({}, baseConfig.globals, config.globals);
    _.defaults(config, baseConfig);
    delete config['extends'];
  }

cfjedimaster added a commit that referenced this pull request Jun 2, 2014
@cfjedimaster
Merge pull request #54 from hacker112/master
7721aa9 
Added support for jshint extends option
@cfjedimaster cfjedimaster merged commit 7721aa9 into cfjedimaster:master Jun 2, 2014
@cfjedimaster
Copy link
Copy Markdown
Owner

cfjedimaster commented Jun 2, 2014

Thank you!

@hacker112
Copy link
Copy Markdown
Contributor Author

hacker112 commented Jun 2, 2014

Well thank you for letting me participate :-)

@busykai busykai mentioned this pull request Dec 22, 2014
Open
@miqmago
Copy link
Copy Markdown

miqmago commented Oct 1, 2015

Cool option!
Is there any possibility to extend "jshint.globals" under "Debug > Open Preferences File" with this option?

I've tried with

{
    "extends": "",
    ...
}

with no success (in fact I'm getting Bad option: 'extends')

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@hacker112 @cfjedimaster @miqmago
⚡